This page has 0 threads | Add post

Blogs

Finding our blogs useful? Please consider helping us to share more!

Wise Owl have found one SQL structure which slows down code more than any other
If your stored procedures or SQL queries are running slowly, don't bother looking at correlated subqueries, cursors, functions or any of the other usual culprits. There's one SQL syntax which Wise Owl have found to be an order of magnitude worse than any other, as this blog shows.

Posted by Andy Brown on 13 May 2019

Stored procedure running slowly? Here's the likely culprit

In general our stored procedures aren't that time-critical: we just don't have enough data for them to matter. But one procedure was seizing up our internal Intranet. It used lots of possible culprits:

Possible culprit	Notes
User-defined functions	Everything I read says that scalar functions are slow.
Multiple criteria	My SQL statement had about 15 criteria in.
Nested functions	One scalar function called another.

I tried removing all of these, but the procedure still took over 10 seconds to run. Finally, I found the culprit - some really sloppy programming, because I'm always short of time when I write these things:

-- use main address if gmail, etc

IF EXISTS (

SELECT *

FROM tblUrlHome AS u

WHERE u.UrlHomeName = @DomainMain

)

SET @email = @EmailAddress

So I changed this to code which is almost as sloppy:

-- use main address if gmail, etc

DECLARE @NumberMain AS int = (

SELECT COUNT(*)

FROM tblUrlHome AS u

WHERE u.UrlHomeName = @DomainMain

)

IF @NumberMain > 0

SET @email = @EmailAddress

The difference? The use of IF EXISTS within a function. Lots of websites will tell you the SQL structures you should avoid, but this seems to me to be an order of magnitude slower than correlated subqueries, dynamic SQL, scalar functions, cursors and any of the other usual suspects.

Some other pages relevant to the above blog include:

This blog has 0 threads

Add a new post

Head office

Kingsmoor House

Railway Street

GLOSSOP

SK13 2AA

London

Landmark Offices

99 Bishopsgate

LONDON

EC2M 3XD

Manchester

Holiday Inn

25 Aytoun Street

MANCHESTER

M1 3AE

Site map

Terms & Conditions

Book any course as classroom, onsite or online training, or as one-to-one consultancy

Free resources

Paid services

Getting help

Where we are

Where you are

Online

Transparent reviews

Delivery of courses

Nicer to work with

Reliable and established

Our training courses

C#

Excel

MySQL

Power Apps

Power Automate

Power BI and DAX

Python

Report Builder

SQL

SQL Server

VBA Macros

Other training resources

Blogs

Exercises

YouTube tutorials

YouTube shorts

Test your skills

Consultancy

Courseware

Self-paced courses

Newsletters

Publications

Our training venues

London

Manchester

Across the UK

At your site

Online

Why we are different

Hundreds of published reviews

Small class sizes

Outstanding courseware

Online classroom

(Almost) no cancellations

Wise Owl trainers only

Genuine integrity

Invoices after training

30+ years of Wise Owl

Our top 100 clients

BLOGS BY TOPIC

BLOGS BY AUTHOR

Stored procedure running slowly? Here's the likely culprit

Head office

London

Manchester